Bugfix: writevtk with empty parts #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR to solve a quite niche issue that happens when we try to write out a pvtk file where some of the files are empty, i.e when the Triangulation is empty in some processors.
In that case, we would still be creating a file per processor and end up with some empty files. Notably, these empty files would be missing the tags for the fields we wanted to export. This breaks the paraview import, making the files unusable.
As a solution, I filter out the processors with empty Triangulations and remap the processor ids to only create as many files as nonempty processors.
Edit: This has now been tested with fairly complicated meshes and more than 100 processors, and everything seems to work fine. The only question then is if this is the best approach or not.