Exploring ghost optimisation #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We now save block PRanges for reuse later - Modified constructors for SparseMatrixAssemblers
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## block-assemblers-v0.3 #128 +/- ##
======================================================
Coverage 0.00% 0.00%
======================================================
Files 11 12 +1
Lines 2242 2402 +160
======================================================
- Misses 2242 2402 +160
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Tests will not fail after the release of Gridap v0.17.20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo/Done:
consistent_local_viewsandchange_ghost. Expand functionality ofchange_ghost.OwnAndGhostVectoras vector partition of resultingPVectors, as a way to reduce memory copying when transferring between FESpace and linear system layouts.BlockPArray <: AbstractBlockArray, a new type that behaves as aBlockArray{PArray}and which fulfills the APIs of bothPArrayandAbstractBlockArray. This will get rid of the type piracy we have been using up to now and gets rid of some of the issues we are having (mainly, the fact thatBlockArrayexpects its blocks to be indexable).MultiFieldFESpace{<:BlockMultiFieldStyle}now has aBlockPRangeas gids, which makes the fespace dof vector be of typeBlockPVector. This is necessary to create consistency between fespace and system vectors, which in turn avoids memory allocations/copies when transferring between FESpace and linear system layouts.To Think:
BlockPArrayconstructors work withBlockPRanges, which is inconsistent with PartitionedArrays. Should we be trying to be coherent? How can we do it well for dispatching?Left for another PR:
PRangeghost-related optimisations while assembling the system matrix. This will create linear systems which ghost layout is compatible with the original FESpace, avoiding copying data when transferring between FESpace and linear system layouts.