Block assemblers for v0.3 #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tributed.jl into block-assemblers-v0.3
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #124 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 11 12 +1
Lines 2082 2448 +366
=======================================
- Misses 2082 2448 +366
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Exploring ghost optimisation
…block-assemblers-v0.3
…block-assemblers-v0.3
|
Hey @amartinhuertas , I think I'm ready to merge this. Any final thougts? |
No. Please go ahead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements block assemblers, which allow to assemble a MultiFieldFESpace block-wise. It is the distributed counterpart of gridap/Gridap.jl#915.
Instead of a sparse monolithic matrix and vectors, this assembler leverages BlockArrays.jl to produce equivalent block-partitioned sparse matrices and vectors. This is meant to ease the development of block preconditioners and solvers.
TODO:
to_parray_of_arraysandlocal_viewsimplementations for BlockArrays to theAlgebra.jlfile?change_ghostsvariant for Block-Multifield, like in the tests? This would give us a way to move from dof partitions to matrix partitions (since having identical PRanges is for now discarded as a solution). Or we could just not solve the issue, since it is already present for non-block assembly as well.Other pains/doubts about the implementation can be found in gridap/GridapSolvers.jl#29.