Merge pull request #959 from gridap/bugfix_add_entry

Bugfix: add_entry! for PSparseMatrices
gridap · Dec 2, 2023 · cc54283 · cc54283
2 parents 4a76c17 + a639b11
commit cc54283
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - `BlockMultiFieldStyle` available for `TransientMultiFieldFESpaces` since PR [#946](https://github.com/gridap/Gridap.jl/pull/946).
 - When creating `DiscreteModelPortions`, some of the `FaceLabeling` arrays were being aliased. This caused issues when adding tags to distributed models in debug mode. Since PR [#956](https://github.com/gridap/Gridap.jl/pull/956).
+- Function `add_entry!` was inconsistent for `AbstractMatrix` and `AbstractSparseMatrix`. Since PR[#959](https://github.com/gridap/Gridap.jl/pull/959).
 
 ## [0.17.20] - 2023-10-01 
 

diff --git a/src/Algebra/AlgebraInterfaces.jl b/src/Algebra/AlgebraInterfaces.jl
@@ -444,7 +444,7 @@ function add_entry!(combine::Function,A::AbstractSparseMatrix,v::Number,i,j)
   k = nz_index(A,i,j)
   nz = nonzeros(A)
   Aij = nz[k]
-  nz[k] = combine(v,Aij)
+  nz[k] = combine(Aij,v)
   A
 end
 

diff --git a/src/Algebra/SymSparseMatrixCSR.jl b/src/Algebra/SymSparseMatrixCSR.jl
@@ -35,7 +35,7 @@ function add_entry!(combine::Function,A::SymSparseMatrixCSR,v::Number,i,j)
     k = nz_index(A,i,j)
     nz = nonzeros(A)
     Aij = nz[k]
-    nz[k] = combine(v,Aij)
+    nz[k] = combine(Aij,v)
   end
   A
 end