Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add json #54

wants to merge 1 commit into from

Conversation

omzouai-visor
Copy link
Contributor

Adds json tags to allow for (un)marshaling into json.

Copy link
Member

@mickeyreiss mickeyreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (not 100% sure if the omitempty logic should be the same or different for JSON).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants