Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync fork #18

Merged
merged 47 commits into from
Mar 5, 2024
Merged

Sync fork #18

merged 47 commits into from
Mar 5, 2024

Conversation

hnicolaysen
Copy link

@hnicolaysen hnicolaysen commented Mar 4, 2024 •
edited
Loading

Sync our master with upstream/master at the latest tag v0.17.0.

lorenzodonini and others added 30 commits November 16, 2022 21:48
@lorenzodonini
Add IsConnected utility method for charge points
983d863 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
fix: use go-routines in handle functions to prevent blocking the unde…
564c732 
…rlying websocket when the callback functions are blocking
@lorenzodonini
Make SampledValue.Value field not required
956223d 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
v1.6: Change ChargingProfileStatus value from NotImplemented to NotSu…
e66011a 
…pported

Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
v2.0.1: Fix incorrect IdTokenType
b542323 
fixes occurrences in:
- reservation.ReserveNow
- remotecontrol.RequestStartTransaction

Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
v2.0.1: Fix csms example after merging lorenzodonini#163
2fa5412 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Use correct name to validate ClearChargingProfileConfirmation
8c6098d
@lorenzodonini
Add debug logs for raw json messages
0195c3f 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
EscapeHTML configuration for json.Marshal
70f4614
@lorenzodonini
Remove newline from encoded json byte array
fc83394 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Fix property constraint violation on ConfigurationKey nil values
0374c84 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Remove incorrect validation for IdToken in RequestStartTransactionReq…
3c24b0d 
…uest

Signed-off-by: Lorenzo <[email protected]>
@dwibudut @lorenzodonini
feature to add a custom client validation handler before connected
5869d11
@dwibudut @lorenzodonini
add/implement SetCheckClientHandler method on MockWebsocketServer
404fb1f
@dwibudut @lorenzodonini
fix/replace with direct func type arg on implement method SetCheckCli…
7652fcf 
…entHandler on MockWebsocketServer
@dwibudut @lorenzodonini
implement method SetNewChargingStationValidationHandler on ocpp1.6 …
fc3ab08 
…(central system)
@shiv3 @lorenzodonini
Add handler
7d6d270
@shiv3 @lorenzodonini
Add router to non tls server
22b4f86
@shiv3 @lorenzodonini
Fix goimport
b979d02
@lorenzodonini
Fix CallError marshaling of empty fields
3facaad 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add send response error handling function
c3dee61 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add error handling function for server SendResponse
3fbe338 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Improve error handling and rewrite tests
0ae68c7 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Convert v1.6 core listeners to pointer receiver
dfa368e 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Fix v1.6 error handling in sendResponse functions
830bc32 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add v1.6 tests for new error handling
9490eba 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Fix v2.0.1 error handling in sendResponse functions
3430e25 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add v2.0.1 tests for new error handling
3ec1db9 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Fix broken tests
782920b 
Signed-off-by: Lorenzo <[email protected]>
@sc-atompower @lorenzodonini
resolves issues/173 checking and handling invalid message property fo…
c38d419 
…r CALL_ERROR.
sc-atompower and others added 17 commits April 17, 2023 21:30
@sc-atompower @lorenzodonini
reverted go.mod
3ecaf00
@lorenzodonini
Fix SetVariableStatus validation tag
0c73967 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
fix messagesinqueue json
34d3b60
@lorenzodonini
Change messageinqueue to messagesinqueue
e034d39
@lorenzodonini
Fix validation override between v1.6 and v2.0.1
c34f6ad 
Signed-off-by: Lorenzo <[email protected]>
@dwibudut @lorenzodonini
fix certificateType on CertificateSignedRequest & GetInstalledCertifi…
694d985 
…cateIds request-response (base on json schemas)
@dwibudut @lorenzodonini
add another FirmwareStatus type on FirmwareStatusNotification (suppor…
69eec62 
…t in ocpp2.0.1)
@lorenzodonini
Fix deadlock on double client stop
118355f 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Override FormatViolation error code for v2.0.1
290c89e 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add tests for FormatViolation value
2fef296 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
Add hook for custom handling of invalid messages
3760b41 
Signed-off-by: Lorenzo <[email protected]>
@lorenzodonini
change serial number validate max to 40
d0d7f6d
@lorenzodonini
Serial number in OCS Request need to be change as well
ff45def
@dwibudut @lorenzodonini
add IdTokenType MacAddress
139992c
@lorenzodonini
add key16 and key201 to resetType and resetStatus
fa5b59a
@lorenzodonini
check type on action in call and add test
f0af2ad
@lorenzodonini
Fix assertion for invalid TLS certificate test
c686786 
Signed-off-by: Lorenzo <[email protected]>
@hnicolaysen hnicolaysen added the enhancement New feature or request label Mar 4, 2024
@hnicolaysen hnicolaysen requested a review from dammarco March 4, 2024 11:43
@hnicolaysen hnicolaysen self-assigned this Mar 4, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8139558405

Details

  • 211 of 261 (80.84%) changed or added relevant lines in 18 files are covered.
  • 8 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+1.2%) to 89.114%
Changes Missing Coverage Covered Lines Changed/Added Lines %
ocppj/ocppj.go 24 27 88.89%
ocppj/client.go 47 52 90.38%
ocpp1.6/charge_point.go 14 20 70.0%
ocpp2.0.1/charging_station.go 15 22 68.18%
ocppj/server.go 37 45 82.22%
ocpp1.6/central_system.go 13 23 56.52%
ocpp2.0.1/csms.go 18 29 62.07%
Files with Coverage Reduction New Missed Lines %
ocpp1.6/charge_point.go 1 69.55%
ws/websocket.go 2 90.24%
ocpp1.6/central_system.go 5 70.19%
Totals Coverage Status
Change from base Build 3477609330: 1.2%
Covered Lines: 6500
Relevant Lines: 7294
💛 - Coveralls

@dammarco
Copy link

dammarco commented Mar 5, 2024

Sure, we can sync the master. But as discussed, syncing our branch where the BDL extension lies, is not that easy 🤔

@hnicolaysen
Copy link
Author

Let's still sync the master. Then we either rebase the gridx-extensions branch or we just cherry-pick as discussed :)

@hnicolaysen hnicolaysen merged commit 607bfeb into master Mar 5, 2024
2 checks passed
@hnicolaysen hnicolaysen deleted the sync-fork branch March 5, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammarco dammarco dammarco approved these changes

Assignees

@hnicolaysen hnicolaysen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@hnicolaysen @coveralls @dammarco @lorenzodonini @dwibudut @shiv3 @sc-atompower