[DOCS] Update Row Condition guidance #10736
Open
+14
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## develop #10736 +/- ##
===========================================
- Coverage 80.53% 80.50% -0.03%
===========================================
Files 463 463
Lines 40233 40233
===========================================
- Hits 32401 32391 -10
- Misses 7832 7842 +10 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
klavavej
commented
Dec 4, 2024
| @@ -39,6 +39,8 @@ Great Expectations allows you to specify conditions for validating rows using th | |||
|
|
|||
| The `condition_parser` defines the syntax of `row_condition` strings. When implementing Expectation conditions with pandas, set this argument to `"pandas"`. | |||
|
|
|||
| Note that the Expectation with conditions will fail if the Batch being validated is from a different type of Data Source than indicated by the `condition_parser`. | |||
There was a problem hiding this comment.
note for reviewer: I couldn't get this to indent properly without moving it into the tab items
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://greatexpectations.atlassian.net/browse/DOC-917. Note that the issue is fairly old and many of the pain points noted in it had already been resolved as a byproduct of other work. So, this PR turned out to be relatively small. I snuck in a few bonus edits as long as I was touching this content like
fixing indenting
making punctuation consistent
reverting what was supposed to be a temporary change from the last big expectation conditions update
Description of PR changes above includes a link to an existing GitHub issue
PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
Code is linted - run
invoke lint(usesruff format+ruff check)Appropriate tests and docs have been updated
For more information about contributing, visit our community resources.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!