Add email auth #4539

rohitpaulk · 2017-07-08T13:58:06Z

#1052.

This PR allows users to sign-in or create an account on Gratipay using email.

Screenshots

Email HTML

Email text

Signup flow (GIF)

(http://recordit.co/ZJwXHLYiHF)

Signin flow (GIF)

(http://recordit.co/SX6hYCQI7j)

Non-critical items to reticket

Add cron to clean out old email_auth_nonces
When we show 'link expired' upon verification, we only say 'Generate a new one'. Provide a button inline instead (or open the sign-in modal with the error message)

Todo

- instead of _ in URLs—Add email auth #4539 (comment): send_link → send-link #4550
tighten up UI on sign-in—Add email auth #4539 (comment)
tighten up UI on auth/verify
reclaim old account if using the same email? — Add email auth #4539 (comment)
success notification on sign in—Add email auth #4539 (comment)
better harmonize Participant.with_*—Add email auth #4539 (comment)
can we integrate emails and accounts elsewhere?—Add email auth #4539 (comment)
tighten up some comments/copy: Tinker with comments and copy #4551

chadwhitacre · 2017-07-17T23:53:19Z

Re: feature flags:

https://martinfowler.com/articles/feature-toggles.html
https://martinfowler.com/bliki/FeatureToggle.html

Many caveats and best practices in there, e.g.:

Savvy teams view the Feature Toggles in their codebase as inventory which comes with a carrying cost and seek to keep that inventory as low as possible. In order to keep the number of feature toggles manageable a team must be proactive in removing feature toggles that are no longer needed. Some teams have a rule of always adding a toggle removal task onto the team's backlog whenever a Release Toggle is first introduced. Other teams put "expiration dates" on their toggles. Some go as far as creating "time bombs" which will fail a test (or even refuse to start an application!) if a toggle is still around after its expiration date. We can also apply a Lean approach to reducing inventory, placing a limit on the number of toggles a system is allowed to have at any one time. Once that limit is reached if someone wants to add a new toggle they will first need to do the work to remove an existing toggle.

In the interest of standardizing URLs. Current count is 60 - vs. 6 _.

chadwhitacre · 2017-07-18T00:18:28Z

I see so many similarities between email and accounts elsewhere. We talked about this before (should dig up): why don't we expand the accounts elsewhere machinery to encompass emails?

chadwhitacre · 2017-07-18T00:22:18Z

gratipay/models/participant/__init__.py

+    def with_email_and_username(cls, email, username):
+        """Return a new participant with given email and username
+        """
+        username = username and username.strip()


Why not just username = username.strip()?

And why not push that down into _validate?

chadwhitacre · 2017-07-18T00:25:53Z

gratipay/models/participant/__init__.py

@@ -81,6 +81,28 @@ def with_random_username(cls):
        return cls.from_username(username)

    @classmethod
+    def with_email_and_username(cls, email, username):


I'd prefer to see this use the existing username.safely_reserve infrastructure for consistency and code reduction.

chadwhitacre · 2017-07-18T00:32:43Z

scss/components/modal.scss

@@ -46,7 +46,7 @@
    text-align: center;
    display: none;
    background: transparentize($light-brown, 0.3);
-    z-index: 1000;
+    z-index: 900;


I assume this is for a reason, ya?

mattbk · 2017-07-18T03:22:18Z

Running into issues on my Macbook, but still running fine on the Ubuntu VM.

chadwhitacre · 2017-08-14T15:40:36Z

Rebased, was 114f36c.

chadwhitacre · 2017-09-07T22:27:17Z

Coming back here from #4604 ... I am thinking about taking the stub participant approach discussed at ... somewhere? We already have plumbing for routes and exchanges and email addresses, seems wrong to duplicate those to enable anon to make payments. Better to stub out a participant, send a normal email verification, and then populate the return page with a "Confirm Payment" section similar to how we could do package claims on the receiver side.

chadwhitacre · 2017-09-07T22:28:39Z

I am thinking about taking the stub participant approach discussed at ... somewhere?

#4547 (comment)

send_link → send-link

rohitpaulk · 2017-11-10T13:16:46Z

Closing as stale

rohitpaulk force-pushed the add-email-sign-in branch 7 times, most recently from 9be01a3 to 8ba8127 Compare July 11, 2017 05:38

rohitpaulk changed the title ~~Add email sign in (WIP)~~ Add email sign in - part 2 (WIP) Jul 11, 2017

rohitpaulk changed the base branch from master to add-email-sign-in-1 July 11, 2017 05:49

rohitpaulk force-pushed the add-email-sign-in branch from 8ba8127 to 7a59215 Compare July 11, 2017 05:51

rohitpaulk mentioned this pull request Jul 11, 2017

Add email sign in - Part 1 #4543

Closed

1 task

rohitpaulk changed the title ~~Add email sign in - part 2 (WIP)~~ Add email sign in - Part 2 (WIP) Jul 11, 2017

rohitpaulk force-pushed the add-email-sign-in branch 2 times, most recently from b435633 to f82f314 Compare July 11, 2017 11:14

rohitpaulk force-pushed the add-email-sign-in-1 branch 2 times, most recently from 062cc52 to b2d6fe1 Compare July 13, 2017 09:36

rohitpaulk force-pushed the add-email-sign-in branch 3 times, most recently from 26bad64 to 06056fa Compare July 13, 2017 09:54

rohitpaulk force-pushed the add-email-sign-in-1 branch from b2d6fe1 to b317926 Compare July 13, 2017 09:55

rohitpaulk force-pushed the add-email-sign-in branch from 06056fa to bd7d0c1 Compare July 13, 2017 09:57

rohitpaulk force-pushed the add-email-sign-in-1 branch from b317926 to d4a22db Compare July 13, 2017 09:59

rohitpaulk force-pushed the add-email-sign-in branch from bd7d0c1 to 11ebe8a Compare July 13, 2017 10:16

rohitpaulk force-pushed the add-email-sign-in-1 branch from d4a22db to 6713c9a Compare July 13, 2017 10:16

rohitpaulk force-pushed the add-email-sign-in branch from 11ebe8a to 171cf54 Compare July 13, 2017 10:52

rohitpaulk changed the base branch from add-email-sign-in-1 to master July 14, 2017 14:40

rohitpaulk force-pushed the add-email-sign-in branch 4 times, most recently from 28d9225 to c0d2aca Compare July 15, 2017 12:21

send_link -> send-link

2d73dd7

In the interest of standardizing URLs. Current count is 60 - vs. 6 _.

chadwhitacre reviewed Jul 18, 2017

View reviewed changes

This was referenced Jul 18, 2017

Tinker with comments and copy #4551

Merged

send_link → send-link #4550

Merged

mattbk mentioned this pull request Jul 19, 2017

Login modal still mentions that one can create an account on Gratipay #4554

Closed

chadwhitacre mentioned this pull request Aug 14, 2017

Pay for package.json in aggregate #4569

Closed

7 tasks

chadwhitacre force-pushed the queue-email-without-participant branch from 3d2430c to b80f821 Compare August 14, 2017 13:55

chadwhitacre force-pushed the queue-email-without-participant branch from b80f821 to 4bc67bc Compare August 14, 2017 16:05

This was referenced Aug 14, 2017

Support queueing emails without participants #4548

Merged

✈️ Give to package.json #4427

Closed

chadwhitacre force-pushed the queue-email-without-participant branch 7 times, most recently from 89a3ed3 to 13a8cc9 Compare September 1, 2017 19:19

mattbk mentioned this pull request Sep 7, 2017

PHP Telegram Bot gratipay/project-review#567

Closed

Merge pull request #4550 from gratipay/dash-over-underscore

da7f739

send_link → send-link

rohitpaulk closed this Nov 10, 2017

chadwhitacre deleted the add-email-sign-in branch November 10, 2017 14:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add email auth #4539

Add email auth #4539

rohitpaulk commented Jul 8, 2017 •

edited by chadwhitacre

Loading

chadwhitacre commented Jul 17, 2017

chadwhitacre commented Jul 18, 2017

chadwhitacre Jul 18, 2017 •

edited

Loading

chadwhitacre Jul 18, 2017

chadwhitacre Jul 18, 2017

chadwhitacre Jul 18, 2017

mattbk commented Jul 18, 2017

chadwhitacre commented Aug 14, 2017

chadwhitacre commented Sep 7, 2017

chadwhitacre commented Sep 7, 2017

rohitpaulk commented Nov 10, 2017

Add email auth #4539

Add email auth #4539

Conversation

rohitpaulk commented Jul 8, 2017 • edited by chadwhitacre Loading

Screenshots

Non-critical items to reticket

Todo

chadwhitacre commented Jul 17, 2017

chadwhitacre commented Jul 18, 2017

chadwhitacre Jul 18, 2017 • edited Loading

Choose a reason for hiding this comment

chadwhitacre Jul 18, 2017

Choose a reason for hiding this comment

chadwhitacre Jul 18, 2017

Choose a reason for hiding this comment

chadwhitacre Jul 18, 2017

Choose a reason for hiding this comment

mattbk commented Jul 18, 2017

chadwhitacre commented Aug 14, 2017

chadwhitacre commented Sep 7, 2017

chadwhitacre commented Sep 7, 2017

rohitpaulk commented Nov 10, 2017

rohitpaulk commented Jul 8, 2017 •

edited by chadwhitacre

Loading

chadwhitacre Jul 18, 2017 •

edited

Loading