This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Start recording ref when recording an exchange in masspay #4518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @whit537 @rohitpaulk |
This was referenced Jun 15, 2017
Closed
kaguillera
force-pushed
the
record-ref-in-masspay
branch
from
15cd569 to
1fc032c
Compare
chadwhitacre
force-pushed
the
record-ref-in-masspay
branch
from
1fc032c to
067c661
Compare
|
LGTM. |
15 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per @dmk246 suggestion here #4361 only took care of exchanges that recorded charges to participants. Masspay which is used for payouts were still recording NULL refs since there was no way to record a ref via
record_an_exchange.sptThis PR is to fix this issue.