Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Provide discovery via package.json #4507

Merged
merged 1 commit into from
Jun 16, 2017
Merged

Provide discovery via package.json #4507

merged 1 commit into from
Jun 16, 2017

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Jun 7, 2017 •
edited
Loading

Close the loop, barely, on #4427.

Todo

  • add tabs to /on/npm/ with stub for default, uploading a package.json
  • style tabs
  • implement package.json pasting and parsing
  • differentiate the approval states
  • fix email whack-a-mole
  • fix CSS regressions
  • make sure this is available to anon

This was referenced Jun 7, 2017
Closed
Closed
@chadwhitacre
Copy link
Contributor Author

My plan is to put this on the /on/npm/ page along with bulk claiming, with an initial prompt to differentiate intention.

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-06-07 at 2 52 28 pm

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from cba27ad to 35c0b0a Compare June 7, 2017 19:44
@chadwhitacre
Copy link
Contributor Author

wlyc45enrj

@chadwhitacre
Copy link
Contributor Author

vrzhadxyzq

@chadwhitacre
Copy link
Contributor Author

Look familiar? We're right back to #4135 (comment). ☺️

screen shot 2016-10-16 at 10 31 34 pm

@chadwhitacre
Copy link
Contributor Author

https://docs.npmjs.com/files/package.json

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 6978124 to 87f377b Compare June 7, 2017 22:16
@chadwhitacre
Copy link
Contributor Author

So can we repurpose the project-listing.html template for this? I am thinking we want our own (still punting on refactoring all that).

@chadwhitacre
Copy link
Contributor Author

screen shot 2017-06-08 at 5 06 36 pm

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 9, 2017 •
edited
Loading

Alright, let's maybe cram this all into one test case.

  • claimed - name changed
  • claimed - approved
  • claimed - unreviewed
  • claimed - rejected
  • unclaimed
  • unknown

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch 2 times, most recently from 0efd635 to 55e21aa Compare June 9, 2017 19:54
@chadwhitacre
Copy link
Contributor Author

55e21aa

screen shot 2017-06-09 at 3 26 48 pm

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 9, 2017 •
edited
Loading

Kinda ridiculous to be hitting these whack-a-mole testing issues:

  1. email race condition → e22cfe7
  2. fake data collision → 6a8b4cb

... and of course a couple npm/network failures for good measure (not linkable w/ build restarted, but #4511). 😅

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 7f76e26 to 6a8b4cb Compare June 9, 2017 20:37
@chadwhitacre
Copy link
Contributor Author

Good lord I hit another one! 😩

@chadwhitacre
Copy link
Contributor Author

/me restarts https://travis-ci.org/gratipay/gratipay.com/builds/241344561 ...

@chadwhitacre
Copy link
Contributor Author

3c22a1b

screen shot 2017-06-09 at 4 47 29 pm

@chadwhitacre
Copy link
Contributor Author

Email whack-a-mole (number 1) is not fixed. Restarting ...

@chadwhitacre
Copy link
Contributor Author

I'm putting this in Review, @mattbk @rohitpaulk et al. Have at it!

@chadwhitacre chadwhitacre force-pushed the bulk-npm branch 2 times, most recently from e18babf to 585f16e Compare June 12, 2017 15:21
@chadwhitacre
Copy link
Contributor Author

Rebased, was 3c22a1b.

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 3c22a1b to 528077d Compare June 12, 2017 15:22
@chadwhitacre chadwhitacre mentioned this pull request Jun 12, 2017
Merged
13 tasks
@chadwhitacre chadwhitacre force-pushed the bulk-npm branch 3 times, most recently from d9242ab to 6fc28cc Compare June 14, 2017 17:25
@chadwhitacre
Copy link
Contributor Author

Rebased after significant refactoring on #4488, was c92d7f3.

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from c92d7f3 to 2d0132e Compare June 14, 2017 17:29
@chadwhitacre
Copy link
Contributor Author

Looks like we've got some CSS regressions:

screen shot 2017-06-14 at 1 45 05 pm

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 2d0132e to d29a724 Compare June 14, 2017 18:32
@chadwhitacre
Copy link
Contributor Author

Regressions fixed! Fixes included in new 395303c and cdc2a5b.

@chadwhitacre
Copy link
Contributor Author

In 034614f I flipped it so anon can search for packages, no need for a sign-in wall for that.

screen shot 2017-06-14 at 4 04 33 pm

@chadwhitacre
Copy link
Contributor Author

Ooh! Ooh! Ghost includes mysql, which is already on Gratipay! Let's make sure clicking "Find packages" by default shows a package to actually really give to.

@chadwhitacre
Copy link
Contributor Author

b81084e 💃

92bg95xs2b

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 14, 2017 •
edited
Loading

Blorp. Follow-on is rough. Click an unclaimed package and you get a prompt to sign in to accept payments. But you were there to give payments! And if you click "Back" you get a form post reconfirmation. 😕

screen shot 2017-06-14 at 4 41 12 pm

screen shot 2017-06-14 at 4 41 56 pm

@chadwhitacre
Copy link
Contributor Author

Pledging (#4195) will help I guess.

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 8fdc4a0 to bf38cdb Compare June 15, 2017 01:12
@chadwhitacre
Copy link
Contributor Author

Tweaked slightly in bf38cdb:

screen shot 2017-06-14 at 9 08 24 pm

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 15, 2017 •
edited
Loading

4123b40:

screen shot 2017-06-15 at 2 45 01 pm
screen shot 2017-06-15 at 2 45 19 pm

@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch 2 times, most recently from 4123b40 to 781edd0 Compare June 15, 2017 19:38
@chadwhitacre
Copy link
Contributor Author

Squashed and busting up. Was 781edd0.

@chadwhitacre chadwhitacre mentioned this pull request Jun 15, 2017
Merged
@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 781edd0 to 2431197 Compare June 15, 2017 19:43
@chadwhitacre chadwhitacre changed the base branch from bulk-npm to refactor-for-package-json June 15, 2017 19:43
@chadwhitacre chadwhitacre force-pushed the refactor-for-package-json branch from 30878fb to 840b639 Compare June 16, 2017 12:25
@chadwhitacre chadwhitacre force-pushed the package-json-discovery branch from 2431197 to 54db2ca Compare June 16, 2017 12:27
@rohitpaulk rohitpaulk changed the base branch from refactor-for-package-json to master June 16, 2017 12:38
@rohitpaulk rohitpaulk merged commit 3d530f5 into master Jun 16, 2017
@rohitpaulk rohitpaulk deleted the package-json-discovery branch June 16, 2017 12:48
@chadwhitacre chadwhitacre mentioned this pull request Jun 16, 2017
Closed
18 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chadwhitacre @rohitpaulk