Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Fix regression from #3975 #4204

Merged
merged 3 commits into from
Nov 25, 2016
Merged

Fix regression from #3975 #4204

merged 3 commits into from
Nov 25, 2016

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Nov 23, 2016

@chadwhitacre
Copy link
Contributor Author

This doesn't indicate actual data corruption, and it isn't affecting user experience, so I'm going to leave this sit for now (not self-merge). I will hopefully see about a test or two after supper.

@chadwhitacre
Copy link
Contributor Author

CHECK_DB_EVERY is set to 10 minutes in production.

@chadwhitacre
Copy link
Contributor Author

So I expect 6 or 7 more entries in Sentry when I get back. :-)

@chadwhitacre
Copy link
Contributor Author

Actually, this may go deeper. I'm struggling to get a test together.

@chadwhitacre
Copy link
Contributor Author

I'm looking at a local backup, finding some patterns ... not all balances are failing the check, for one.

@chadwhitacre
Copy link
Contributor Author

I've whittled down to a failing case with the fewest exchanges.

@chadwhitacre
Copy link
Contributor Author

Okay, I think I've got it. transfers are selected (or payments?) but not the exchanges to offset them.

@chadwhitacre
Copy link
Contributor Author

Alright! Ready to go. :-)

cc: @kaguillera @rohitpaulk @aandis @nobodxbodon @JessaWitzel et al.

@kaguillera
Copy link
Contributor

LGTM...I have no complaints
If no one else has any concerns by Friday I will merge.

@clone1018
Copy link
Contributor

Looks good to me.

@clone1018
Copy link
Contributor

Updating branch (with GitHub) and waiting for tests. I remember us talking about rebasing instead but I'm not setup for that right now

@clone1018 clone1018 merged commit 63cc20b into master Nov 25, 2016
@clone1018 clone1018 deleted the fix-check-balances branch November 25, 2016 00:02
@clone1018
Copy link
Contributor

ok I merged and deleted the branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants