Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Add npm to /search #4147

Closed
wants to merge 1 commit into from
Closed

Add npm to /search #4147

wants to merge 1 commit into from

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented Oct 20, 2016

Add npm packages to /search results.

Add live search over npm packages at /on/npm/, linking over to /on/npm/foo/. Try really really hard to use Libraries.io in some way so we can say "Powered by Libraries.io" and start building that partnership.

Todo

  • while searching, hit npmsearch.com in addition to local index
  • mix the results into results from our local index (compare scores?)

@chadwhitacre chadwhitacre changed the title Pay any npm package Pay for any npm package Oct 20, 2016
@chadwhitacre
Copy link
Contributor Author

Hmm ... do we do this in /on/npm/ or add it to /search?

@chadwhitacre chadwhitacre changed the title Pay for any npm package Search over npm Oct 20, 2016
@chadwhitacre
Copy link
Contributor Author

@aandis at #4148 (comment):

@whit537 I am not seeing any official well documented api for searching packages over npm. Best I could find is https://github.com/wires/npm-keywordsearch through this.

@chadwhitacre chadwhitacre changed the title Search over npm Add npm to /search Oct 21, 2016
@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Oct 21, 2016

I think we should incorporate this into our normal /search, and that we should rework that page to show one list of results instead of several, with the different object types (~user, Team, /on/*/*) represented in some other way than having different listings for each type.

We can leave the social network thing in the sidebar, I guess. It doesn't actually search, it's just a convenience for typing /on/twitter/foo in the browser address bar.

I'd like to see npm packages incorporated into the main results, though. This description of npm search points to npmsearch.com, which has a really promising API. It's fast and light. We may have to go with that instead of Libraries.io. :-/

I've added a todo list to the ticket description.

How's that sound, @aandis? Note ordering of development priorities on #4148 (second todo subsection).

@chadwhitacre
Copy link
Contributor Author

(The work I just spec'd should probably be multiple PRs.)

@chadwhitacre
Copy link
Contributor Author

I moved the separate-PR work out of this ticket description and up into #4148.

@chadwhitacre
Copy link
Contributor Author

npm itself uses https://www.constructor.io/.

@aandis
Copy link
Contributor

aandis commented Oct 21, 2016

How's that sound, @aandis? Note ordering of development priorities on #4148 (second todo subsection).

Cool I'll look into npmsearch's api. Catching up on #4151 since that seems to be priority.

@chadwhitacre
Copy link
Contributor Author

Closing because we want to search over packages in our own database, rather than an external service. Will get to that eventually under gratipay/inside.gratipay.com#987.

@chadwhitacre chadwhitacre deleted the on-npm branch January 24, 2017 22:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants