Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

team preliminaries #4037

Merged
merged 4 commits into from
Jun 25, 2016
Merged

team preliminaries #4037

merged 4 commits into from
Jun 25, 2016

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented May 12, 2016

#3994
#4045

Punchlist

Remake of #4009.

@chadwhitacre
Copy link
Contributor Author

Rebased on master. Preview head was 9d6a8d6.

@chadwhitacre
Copy link
Contributor Author

Alright, picking up from #4023 (comment), let's get a commit on here that converts existing cached values into triggered computations ...

@chadwhitacre
Copy link
Contributor Author

Alright, ticked off the last little item on this PR, and made a new PR for the cached values work: #4045.

@chadwhitacre
Copy link
Contributor Author

Marking this ready for review, @rohitpaulk @aandis et al.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 16, 2016

Blocking on #4062.

@chadwhitacre
Copy link
Contributor Author

Rebased on master, previous head was 53da3c6.

This frees us up to implement additional logic in mixins rather than
running away with the team.py file.
@chadwhitacre
Copy link
Contributor Author

Rebased on master (d6ae1bc), previous head was d3f34b3.

@chadwhitacre
Copy link
Contributor Author

Rebased again to drop 7f54ee4 because of the way the takes proposal is changing at #3994 (comment). Previous head was 234ba4c.

@chadwhitacre
Copy link
Contributor Author

Reopen to kick Travis. Failure was spurious (#4066).

We never used it anyway.
@chadwhitacre
Copy link
Contributor Author

Rebased to not touch the takes table. Now all this PR does is remove the word "payroll" from our codebase, and clarify a variable name. Previous head was 92430d1.

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented Jun 17, 2016

Ready for review, @rohitpaulk @aandis.

@chadwhitacre chadwhitacre mentioned this pull request Jun 17, 2016
4 tasks
@chadwhitacre
Copy link
Contributor Author

Ping @aandis @rohitpaulk. I'd like to start another push on #3994, and this is a prerequisite.

@chadwhitacre chadwhitacre mentioned this pull request Jun 24, 2016
2 tasks
@aandis
Copy link
Contributor

aandis commented Jun 25, 2016

Looks good to me.

@aandis aandis merged commit 6112bbe into master Jun 25, 2016
@chadwhitacre chadwhitacre deleted the team-preliminaries branch July 12, 2016 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants