Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

fix stats #3730

Merged
merged 22 commits into from
Aug 31, 2015
Merged

fix stats #3730

merged 22 commits into from
Aug 31, 2015

Conversation

chadwhitacre
Copy link
Contributor

Closes #3446.

@chadwhitacre
Express age in years
10d9456
@chadwhitacre
Drop extraneous div
b3f87fc 
No longer necessary post-#3718.
@chadwhitacre
Drop low-value charts
d010e49 
The total users/volume charts provide little value because they can only
ever increase. The charges and withdrawals charts don't tell us much
that the weekly volume chart doesn't, especially after #1383.
@chadwhitacre
Rename "Weekly Gifts" to "Weekly Volume"
7c23c5e 
Reflects the move away from individual no-strings-attached tip gifts in
1.0 to voluntary payments in 2.0.
@chadwhitacre chadwhitacre added this to the Refund Announcement milestone Aug 31, 2015
@chadwhitacre chadwhitacre force-pushed the fix-stats branch 2 times, most recently from ea73d1c to 1b752cf Compare August 31, 2015 13:20
@chadwhitacre
Remove sentences about last/this week's volume
21fc122 
That was mostly interesting early on when our time horizon was closer.
Now we don't care as much about intra-week changes to the system as a
whole.
@chadwhitacre
Flip order of active users and volume charts
097cfdb 
Weekly volume is the crucial chart. That's the one I refer to when
telling people the story of Gratipay.
@chadwhitacre
Prune vestigial payday record-keeping method
28ac16d
@chadwhitacre
Greatly simplify the paydays table
aef017a 
We were tracking all sorts of stuff that we never looked at. Let's pare
down to the numbers we actually care about: volume and nactive.
@chadwhitacre
Rename transfer_volume to volume
26611ac 
Having gotten rid of the other *_volume columns, we can simply the name
of this one.
@chadwhitacre
Copy link
Contributor Author

The next step I'm working on is to add a payday column to the transfers table, so that we can recompute volume and nactive in a similar way both pre- and post-Gratipocalypse. However, I have discovered a single record in the transfers table where the amount is negative. We have a positive check constraint now which is catching the error. I'm not sure how the record ended up in there in the first place. It happened in May of last year. The ~user in question has a balance, and the amount is only 33¢. I'm inclined to correct the error using the user's balance.

@chadwhitacre
Copy link
Contributor Author

The user in question was involved in a MassPay snafu: #2417.

@chadwhitacre
Copy link
Contributor Author

Alright, so we have this negative-amount record in transfers, and the bottom line for this ticket is that that record is not going way. I propose to work around it by relaxing the positive check constraint on amount, performing the update, and then reinstating the check constraint.

P.S. The way we ended up with the negative transfer is complicated: our 1.0 payroll implementation computed the amount to transfer to the last person taking as the remainder of the team's balance, and as a result of the MassPay snafu in #2417, the team had a negative balance, so therefore the last person's take was negative!

@chadwhitacre
Copy link
Contributor Author

Positive constraint is in #2723, btw.

@chadwhitacre
Copy link
Contributor Author

Okay, got it. Looks like we have 563 non-payday transfers (take-over, final-gift), and 523,762 payday transfers.

@chadwhitacre
Copy link
Contributor Author

Actually, we don't need to reset the pre-Gratipocalypse values, though we may as well add the payday column to transfers since I've got that ready now.

@chadwhitacre
Fix post-Gratipocalypse payday numbers
395f824
@chadwhitacre
Failing test for stats w/ populated db
1a137e9
@chadwhitacre
Remove giving/receiving/overlap from stats
59d84ff 
This is less interesting now that we have Teams in between. The original
question this was answering was whether Gratipay was just circulating
money around amongst the same few people.
@chadwhitacre
Make the volume stats accurate
69acd79 
They were doubled because we were counting both sides, payment and
payroll. We should just count payment.
@chadwhitacre
Copy link
Contributor Author

I'm seeing a volume spike in 159. What's that about?

screen shot 2015-08-31 at 12 14 53 pm

@chadwhitacre
Copy link
Contributor Author

What's that about?

It was a user with multiple Teams consolidating their funds in one Team as part of getting paid out for the first time.

https://gratipay.freshdesk.com/helpdesk/tickets/2090

@chadwhitacre
Copy link
Contributor Author

Okay! We have accurate volume and active user charts again! :-)

screen shot 2015-08-31 at 12 23 31 pm

@chadwhitacre
Copy link
Contributor Author

Winding down here, ready for review if anyone is around. :)

@chadwhitacre
Clean up the rest of the stats prose
ace42ee 
Properly i18n'd and no more stats.json
@chadwhitacre
Copy link
Contributor Author

screen shot 2015-08-31 at 1 29 50 pm
screen shot 2015-08-31 at 1 29 59 pm

@chadwhitacre chadwhitacre mentioned this pull request Aug 31, 2015
Closed
@chadwhitacre
Copy link
Contributor Author

Ready?

chadwhitacre added a commit that referenced this pull request Aug 31, 2015
@chadwhitacre
Merge pull request #3730 from gratipay/fix-stats
3a2eb68 
fix stats
@chadwhitacre chadwhitacre merged commit 3a2eb68 into master Aug 31, 2015
@chadwhitacre chadwhitacre deleted the fix-stats branch August 31, 2015 20:02
@chadwhitacre chadwhitacre mentioned this pull request Aug 31, 2015
Merged
chadwhitacre added a commit that referenced this pull request Aug 31, 2015
@chadwhitacre
Prune SQL scripts from #3730
55ca89b
This was referenced Aug 31, 2015
Merged
Merged
chadwhitacre added a commit that referenced this pull request Sep 13, 2015
@chadwhitacre
Catch fake data up with #3730. Fixes #3780
637065a 
We removed a number of payday stats fields, but were still trying to
populate those in fake data. This PR also makes db cleaning a little
more robust so we can recover from failure during `make fake`.
@chadwhitacre chadwhitacre mentioned this pull request Sep 13, 2015
Merged
chadwhitacre added a commit that referenced this pull request Sep 13, 2015
@chadwhitacre
Catch fake data up with #3730. Fixes #3780
6d21e44 
We removed a number of payday stats fields, but were still trying to
populate those in fake data. This PR also makes db cleaning a little
more robust so we can recover from failure during `make fake`.
chadwhitacre added a commit that referenced this pull request Sep 19, 2015
@chadwhitacre
Merge pull request #3782 from gratipay/fix-make-fake
2e383b1 
catch fake data up with #3730
@nobodxbodon nobodxbodon mentioned this pull request Jan 18, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Review
Projects
None yet
Milestone
Refund Announcement
Development

Successfully merging this pull request may close these issues.
1 participant
@chadwhitacre