Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Remove mention of bank account on error 400 #3683

Merged
merged 4 commits into from
Aug 19, 2015

Conversation

mattbk
Copy link
Contributor

@mattbk mattbk commented Aug 15, 2015

We only have payouts through PayPal right now, so in order to remove confusion we shouldn’t tell people to attach a bank account when they can’t. #3654

We only have payouts through PayPal right now, so in order to remove
confusion we shouldn’t tell people to attach a bank account when they
can’t.
@mattbk mattbk added the Review label Aug 15, 2015
@mattbk mattbk added this to the Pivot milestone Aug 15, 2015
@chadwhitacre
Copy link
Contributor

@mattbk The *.po translation files are updated automatically underneath release.sh. We shouldn't modify them directly here in this PR.

@mattbk
Copy link
Contributor Author

mattbk commented Aug 17, 2015

Okay, time to learn something new then.

  • Can I change the *.spt files, or does that mess with what messages the translation files are matched to?
  • I should be able to undo the changes I made to the *.po files and keep it all in the same PR, right?

@mattbk mattbk removed the Review label Aug 17, 2015
@chadwhitacre
Copy link
Contributor

Can I change the *.spt files, or does that mess with what messages the translation files are matched to?

You should only change the *.spt files (not the *.po files). During deployment, we extract strings from the *.spt files themselves into i18n/core.po, upload that to Transifex, and then download completed
*.po files from Transifex. This all happens in these Makefile targets. Bottom line: change *.spt files, not *.po files.

I should be able to undo the changes I made to the *.po files and keep it all in the same PR, right?

Yes! Easiest would be to manually edit the *.po files, commit that change, and then push it up to the same branch (error-400-bank-account). How's your git-fu? Want/need more specific pointers than that? :)

@mattbk
Copy link
Contributor Author

mattbk commented Aug 18, 2015

I replaced the *.po files from master but left the *.spt files modified. I think.

@mattbk mattbk added the Review label Aug 18, 2015
@rohitpaulk
Copy link
Contributor

!m @mattbk

@chadwhitacre
Copy link
Contributor

@mattbk Looks like we've got tests for those error messages. Wanna try updating those as well? :)

@mattbk mattbk removed the Review label Aug 19, 2015
@mattbk mattbk added the Review label Aug 19, 2015
@mattbk
Copy link
Contributor Author

mattbk commented Aug 19, 2015

I think it worked?

@chadwhitacre
Copy link
Contributor

You win! :-)

chadwhitacre added a commit that referenced this pull request Aug 19, 2015
Remove mention of bank account on error 400
@chadwhitacre chadwhitacre merged commit 5c876b4 into master Aug 19, 2015
@chadwhitacre chadwhitacre deleted the error-400-bank-account branch August 19, 2015 15:30
@chadwhitacre
Copy link
Contributor

!m @mattbk

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants