Dogecoin support -- wow #2824
Dogecoin support -- wow #2824
Conversation
| @@ -43,6 +43,7 @@ CREATE TABLE participants | |||
| , paypal_email text DEFAULT NULL | |||
| , anonymous_receiving boolean NOT NULL DEFAULT FALSE | |||
| , bitcoin_address text DEFAULT NULL | |||
| , dogecoin_address text DEFAULT NULL | |||
There was a problem hiding this comment.
@rht - We don't make edits to schema.sql directly.
We keep our database schema in schema.sql, and we write schema changes for each PR branch in a branch.sql file, which then gets run against production and appended to schema.sql during deployment.
There was a problem hiding this comment.
Here's an example of a PR with branch.sql :)
|
This PR is 100% code duplication. I don't even know why we have specific support for Bitcoin since you can just put your address in your profile statement, but if you want to add support for other cryptocoins the proper way to do it would be to generalize the Bitcoin code, not duplicate it. |
| ); | ||
|
|
||
| END; | ||
|
|
There was a problem hiding this comment.
We don't have this kind of dedicated table + rule anymore, we put everything in the events table.
There was a problem hiding this comment.
Yeah, this PR is one step to encourage the generalized solution with various cryptocurrencies.
Adding a dedicated payment receiving option is semantically better than putting them all in the profile statement.
|
Thanks for the contribution, @rht! 💃 🐕 |
chadwhitacre
force-pushed
the
master
branch
2 times, most recently
from
cf99c0f to
11fcaf3
Compare
chadwhitacre
force-pushed
the
master
branch
3 times, most recently
from
bb509d8 to
0d20225
Compare
|
I think adding support for dogecoin might be a good idea, but if you're going to add dogecoin then other cryptocurrencies also need to be considered. |
|
@benhc123 thanks for the reminder. Agreed. |
| request.allow("POST") | ||
|
|
||
| bit_address = request.body['dogecoin_address'].strip() | ||
| if bit_address != '' and not bitcoin.validate(bit_address, version=0x1E): |
There was a problem hiding this comment.
What does this version parameter do?
There was a problem hiding this comment.
version=0 is for bitcoin, version=0x1E is for dogecoin.
|
This is no longer blocked, changes to facilitate adding other cryptocoins have been made in #3282. |
|
Changed to |
|
But coinbase doesn't accept dogecoin yet. |
We don't need coinbase to display a dogecoin address on one's profile. |
|
I think Dogecoin has gone out of fashion now. We need support for Bitcoin but for others it's less vital.
|
|
... and I'm not sure we need Bitcoin either (gratipay/inside.gratipay.com#201 (comment)), but that's a separate issue. |
Someone needs to do it. resolves #2685.