-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: configurable key to ID conversion #379
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
==========================================
+ Coverage 94.74% 96.30% +1.55%
==========================================
Files 10 9 -1
Lines 1333 921 -412
==========================================
- Hits 1263 887 -376
+ Misses 70 34 -36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest seems good. Maybe adding a test to ensure that actually querying an object returns as well the expected type (e.g. int not the converted id) might be helpful just for completeness 👍
fixes #102 by giving users the choice to either convert all Key Columns to
graphene.ID
or leave all key columns as is.