-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APQ between subgraph and gateway #313
Conversation
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@graphql-tools/executor-http |
1.2.0-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
3.0.1-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/fusion-runtime |
0.10.20-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway |
1.6.8-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-opentelemetry |
1.3.27-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/plugin-prometheus |
1.3.15-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-hive/gateway-runtime |
1.3.15-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
@graphql-mesh/transport-http |
0.6.26-alpha-52e7c9192bd3022251be5c3cabe546398300b30d |
npm ↗︎ unpkg ↗︎ |
🚀 Snapshot Release (Bun Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared
|
🚀 Snapshot Release (Node Docker Image)The latest changes of this PR are available as image on GitHub Container Registry (based on the declared
|
86e733f
to
9338e8c
Compare
9338e8c
to
52e7c91
Compare
transportEntries: { | ||
greetings: { | ||
options: { | ||
apq: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Transport entries is marked as an advanced feature today. Do we want to hide this behind this setting ?
Perhaps we can have a top level option instead ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are not advanced. It is a way to configure the transport.
I don't think a top level option is a good idea because this feature is specific to HTTP transport.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's advanced, but that's what we are advertising in the documentation ^^'
And the way transport entries work is never actually explain. It's shortly explained in the Subscriptions page because it is needed to configure websocket/http callback subscription transports
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix it then yes. I agree it is a bit low level but i think we should cover each feature individial rather than grouping them into one single transportEntries documentation. What do you think?
Closes #272
Automatic Persisted Queries support for upstream requests
For HTTP Executor;
For Gateway Configuration;