Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use subgraph timestamp for tap #995

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

gusinacio
Copy link
Member

@gusinacio gusinacio commented Aug 28, 2024

Fixes #993
Fixes #994

@gusinacio gusinacio force-pushed the gusinacio/fix-delayed-subgraph-issues branch 7 times, most recently from 44b4fb5 to 3a7c871 Compare August 28, 2024 19:42
@gusinacio gusinacio force-pushed the gusinacio/fix-delayed-subgraph-issues branch from 8519bbe to d80a7d6 Compare August 29, 2024 14:10
@gusinacio gusinacio marked this pull request as ready for review August 29, 2024 14:10
Copy link
Contributor

@carlosvdr carlosvdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sheesh nice, LGTM

@gusinacio gusinacio force-pushed the gusinacio/fix-delayed-subgraph-issues branch from f881922 to 58e425b Compare August 29, 2024 16:06
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
@gusinacio gusinacio requested a review from aasseman August 30, 2024 16:40
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested in prod and it redeems RAVs fine.

@aasseman aasseman requested a review from dwerner September 2, 2024 16:57
@aasseman aasseman merged commit 999fe0d into main Sep 4, 2024
7 of 10 checks passed
@aasseman aasseman deleted the gusinacio/fix-delayed-subgraph-issues branch September 4, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RAVs retry is breaking if subgraph is late Pending RAVs doesn't take into account sender_address
4 participants