-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use subgraph timestamp for tap #995
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gusinacio
force-pushed
the
gusinacio/fix-delayed-subgraph-issues
branch
7 times, most recently
from
August 28, 2024 19:42
44b4fb5
to
3a7c871
Compare
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/fix-delayed-subgraph-issues
branch
from
August 29, 2024 14:10
8519bbe
to
d80a7d6
Compare
carlosvdr
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sheesh nice, LGTM
Signed-off-by: Gustavo Inacio <[email protected]>
gusinacio
force-pushed
the
gusinacio/fix-delayed-subgraph-issues
branch
from
August 29, 2024 16:06
f881922
to
58e425b
Compare
carlosvdr
reviewed
Aug 29, 2024
aasseman
suggested changes
Aug 29, 2024
Signed-off-by: Gustavo Inacio <[email protected]>
Signed-off-by: Gustavo Inacio <[email protected]>
aasseman
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tested in prod and it redeems RAVs fine.
Signed-off-by: Gustavo Inacio <[email protected]>
dwerner
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #993
Fixes #994