Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(indexer-native): neon 1.0.0, napi-6 #975

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix(indexer-native): neon 1.0.0, napi-6 #975

merged 2 commits into from
Aug 2, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Jul 30, 2024

In working to resolve #972, I pulled in some changes from #749, while retaining our prebuilt pipeline.

@dwerner dwerner marked this pull request as ready for review July 30, 2024 20:23
@dwerner dwerner requested a review from fordN July 30, 2024 20:39
@dwerner dwerner force-pushed the indexer-native-fix branch from 77cf8d8 to abdabbd Compare July 31, 2024 18:44
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/indexer-native/native/Cargo.toml Show resolved Hide resolved
packages/indexer-native/package.json Outdated Show resolved Hide resolved
native: remove panics, bump edition

bump indexer-native version

declare napi 6

workflow to test binaries

back out specified napi versions

fix json

remove node 17 support

restore bin publish workflow

ensure lib name is indexer_native
@dwerner dwerner force-pushed the indexer-native-fix branch from abdabbd to 643a314 Compare August 1, 2024 21:20
@dwerner dwerner merged commit 65cdec5 into main Aug 2, 2024
10 checks passed
@dwerner dwerner deleted the indexer-native-fix branch August 2, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

Bug: Seg fault starting Node processes
3 participants