Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agent: if alias does not exist try the actual flag #838

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Conversation

saihaj
Copy link
Member

@saihaj saihaj commented Jan 4, 2024

when trying to run locally for some reason yargs doesn't show me dir as a parsed arg, I would expect it to create aliases automatically so we can reference it. But adding this as safe guards for anyone it doesn't work.

@saihaj saihaj requested a review from fordN January 4, 2024 20:02
when trying to run locally for some reason yargs doesn't show me dir as a parsed arg, I would expect it to create aliases automatically so we can reference it. But adding this as safe guards for anyone it doesn't work.
@saihaj saihaj force-pushed the saihaj/handle-dir branch from 8ce5589 to 2d2c215 Compare January 11, 2024 20:18
@saihaj saihaj changed the title fix(indexer-agent): if alias does not exist try the actual flag agent: if alias does not exist try the actual flag Jan 11, 2024
Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saihaj saihaj merged commit 0f48b17 into main Jan 24, 2024
9 checks passed
@saihaj saihaj deleted the saihaj/handle-dir branch January 24, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants