Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collect tap ravs #831

Closed
wants to merge 10 commits into from
Closed

collect tap ravs #831

wants to merge 10 commits into from

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 7, 2023

  • Import escrow contracts npm package
  • Add sequelize schema and resolvers for scalar_tap_ravs; updated relations between Voucher and AllocationSummary to be compatible with RAV.
  • Define SignedRAV as the equivalence of TAPVerifier.SignedRAVStruct == EIP712SignedMessage<ReceiptAggregateVoucher>
  • RAV processing triggered alongside AllocationReceiptCollector's voucher processing which is in indexer-agent.
  • Add EventualAllocations and EscrowContracts to AllocationReceiptCollector
  • Obtain typed final SignedRAVs from DB, loop through individual SignedRav for individual submissions on-chain
  • Refactored allocationSigner function to provide Signer for computing allocationIDProof as required by escrow.redeem
  • transactionManager to first estimate gas and then execute transaction to contracts.escrow.redeem(signedRAV, allocationIDProof)
  • Upon getting transaction receipt, go ahead deleting RAV from DB.
  • Basic metrics added for RAV

@hopeyen hopeyen force-pushed the hope/collect-tap-ravs branch from 5f0582e to 9041993 Compare December 13, 2023 15:34
@hopeyen hopeyen marked this pull request as ready for review December 14, 2023 15:10
@hopeyen hopeyen changed the title Draft: collect tap ravs collect tap ravs Dec 14, 2023
@hopeyen hopeyen marked this pull request as draft December 14, 2023 20:25
@fordN
Copy link
Contributor

fordN commented Jan 11, 2024

Sorry this is a bit nitpicky: can we keep the commit format consistent with how we've been working in this repo?
<package-name>: <Description of commit>

For example:
agent: Fix bug in stake usage calculation

@gusinacio
Copy link
Member

Continuation of PR is gonna be on #869

@gusinacio gusinacio closed this Mar 14, 2024
@carlosvdr carlosvdr mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants