-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collect tap ravs #831
Closed
Closed
collect tap ravs #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
added
enhancement
New feature or request
status: potential solution
indexer-agent
indexer-common
p2
labels
Dec 7, 2023
hopeyen
force-pushed
the
hope/collect-tap-ravs
branch
from
December 13, 2023 15:34
5f0582e
to
9041993
Compare
Sorry this is a bit nitpicky: can we keep the commit format consistent with how we've been working in this repo? For example: |
11 tasks
Continuation of PR is gonna be on #869 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
scalar_tap_ravs
; updated relations betweenVoucher
andAllocationSummary
to be compatible withRAV
.SignedRAV
as the equivalence ofTAPVerifier.SignedRAVStruct == EIP712SignedMessage<ReceiptAggregateVoucher>
AllocationReceiptCollector
's voucher processing which is inindexer-agent
.EventualAllocations
andEscrowContracts
toAllocationReceiptCollector
SignedRAVs
from DB, loop through individualSignedRav
for individual submissions on-chainallocationSigner
function to provideSigner
for computingallocationIDProof
as required byescrow.redeem
transactionManager
to first estimate gas and then execute transaction tocontracts.escrow.redeem(signedRAV, allocationIDProof)
RAV