Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine subgraph query result shape validation #798

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Refine subgraph query result shape validation #798

merged 1 commit into from
Oct 10, 2023

Conversation

tilacog
Copy link
Contributor

@tilacog tilacog commented Oct 9, 2023 •
edited
Loading

  • Hardening: refine subgraph query result shape validation
  • Bugfix: account for error property named errors and error
  • Bugfix: pass query variables value when recursing

@tilacog tilacog force-pushed the tiago/expand-freshness-check-error-handing branch from 6689e8b to b9fdc74 Compare October 9, 2023 20:45
@tilacog
common: harden freshness subgraph queries and fix recursion bug
ea723f0 
- refine subgraph query result shape validation
- account for error property named 'errors' and 'error'
- pass 'variables' value when recursing
@tilacog tilacog force-pushed the tiago/expand-freshness-check-error-handing branch from c1c942a to ea723f0 Compare October 9, 2023 22:01
@tilacog tilacog requested review from fordN and hopeyen October 9, 2023 22:01
@tilacog tilacog added this to the v0.20.23 milestone Oct 9, 2023
@tilacog tilacog self-assigned this Oct 9, 2023
@tilacog tilacog added bug Something isn't working hardening labels Oct 9, 2023
@tilacog tilacog requested a review from saihaj October 9, 2023 22:50
hopeyen
hopeyen approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏁

@tilacog tilacog merged commit 2e23f93 into main Oct 10, 2023
9 checks passed
@tilacog tilacog deleted the tiago/expand-freshness-check-error-handing branch October 10, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

@fordN fordN Awaiting requested review from fordN

@saihaj saihaj Awaiting requested review from saihaj

Assignees

@tilacog tilacog

Labels
bug Something isn't working hardening
Projects
Indexer
Status: 🚗 Merged
Milestone
v0.20.23
Development

Successfully merging this pull request may close these issues.
2 participants
@tilacog @hopeyen