indexer-agent: align cli args behaviour with network specification behaviour #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to align CLI arg behaviour for indexer-agent transaction settings with that of the same settings when using the network specification config:
https://github.com/graphprotocol/indexer/blob/main/packages/indexer-common/src/network-specification.ts#L66-L80
Specifically, the CLI args, despite the descriptions indicating they are in seconds, are in fact in milliseconds. The same arguments in the network specification are in seconds (because they have the transforms). The same is true for wei vs gwei.
There were also a couple of bugs:
https://github.com/graphprotocol/indexer/compare/chriswessels-patch-2?expand=1#diff-99c7c045e392890d684d7b8eeebc28aff6f48770fbc468722f04b8482719c74aR694
https://github.com/graphprotocol/indexer/compare/chriswessels-patch-2?expand=1#diff-99c7c045e392890d684d7b8eeebc28aff6f48770fbc468722f04b8482719c74aR364