Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: fix subgraph pagination chattyness, fix subgraph pagination #1056

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Dec 11, 2024

Bump subgraph query page size to 1000 as per #1058

Also fixes subgraph pagination that sometimes results in duplicates in this test:

https://github.com/graphprotocol/indexer/blob/main/packages/indexer-common/src/indexer-management/__tests__/helpers.test.ts#L355

Which is leading to this failure in tests sometimes:

https://github.com/graphprotocol/indexer/actions/runs/12281805281/job/34271522211?pr=1055

@graphprotocol/indexer-common:   ● Monitor: CI › Fetch subgraphs
@graphprotocol/indexer-common:     expect(received).toEqual(expected) // deep equality
@graphprotocol/indexer-common:     Expected: 106
@graphprotocol/indexer-common:     Received: 107
@graphprotocol/indexer-common: 
@graphprotocol/indexer-common:       461 |       'HGZgSEpRbwY3H54vyrUfqn8RXqDA23qT9yLqyxZXZTNW',
@graphprotocol/indexer-common:       462 |     ])
@graphprotocol/indexer-common:     > 463 |     await expect(subgraphs.length).toEqual(106)
@graphprotocol/indexer-common:           |                                    ^
@graphprotocol/indexer-common:       464 |   })

Copy link
Contributor

@fordN fordN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dwerner dwerner force-pushed the fixup/subgraph-query-pagination branch from acc2d1c to 7acb873 Compare December 12, 2024 17:46
@dwerner dwerner merged commit 20af261 into main Dec 12, 2024
9 checks passed
@dwerner dwerner deleted the fixup/subgraph-query-pagination branch December 12, 2024 17:52
@dwerner dwerner changed the title common: fix subgraph pagination common: fix subgraph pagination chattyness, fix subgraph pagination Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚗 Merged
Development

Successfully merging this pull request may close these issues.

2 participants