-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use badges to redirect to a release #1037
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is pretty nice , cool
4c457de
to
b294884
Compare
Love this automation! Thanks @gusinacio & @carlosvdr This change the release process and directly affects very important indexer docs referenced every day, so would great to get more buy-in from everyone before merging this type of change in the future. |
Hey, thanks for letting me know about this. It became a big issue with confused indexers running older versions. At the same time, we got a thumbs-up from @trader-payne in Discord so I thought it would be good to merge. Next time I'll bring this for more people to discuss. |
@fordN we've been talking about an automated way of pointing to the Qm hashes and versions since two years now, and even though we had discussions about ENS or using data edge subgraphs for this, nobody took actions. This is what we've come up with in the interim. I think it's a great feature and everyone I've asked so far seems pretty happy with it. The only thing we have to keep in mind going forward is to make sure we don't create releases until things are production ready. It was the same case before anyway, so nothing really changed if you ask me. |
Right, I'm not commenting on the solution. I love the automation. ❤️ It's just something we now have to be aware of in process (changes process and assumptions a bit), so we all need to be aware of it before executing the change. |
@trader-payne Which I clearly stated in my original message, so I don't get why you are framing my comment as being against automation or against the solution itself or using the "nobody took action" point to justify not letting everyone know of the new process. |
Makes sense @fordN, my bad! I'm half responsible for this merge as I asked Gustavo to do it once I saw easy it was to solve the problem 😬 But yeah you're right! |
No description provided.