Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add config for receipts domain #82

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix: add config for receipts domain #82

merged 1 commit into from
Oct 24, 2023

Conversation

Theodus
Copy link
Member

@Theodus Theodus commented Oct 24, 2023

This adds the config options, chain_id & verifying_contract, required to contruct the EIP-712 domain used when verifying receipts.

This adds the config options, `chain_id` & `verifying_contract`,
required to contruct the EIP-712 domain used when verifying receipts.
@Theodus Theodus requested review from aasseman and hopeyen October 24, 2023 15:23
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6629022963

  • 0 of 6 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 42.979%

Changes Missing Coverage Covered Lines Changed/Added Lines %
service/src/config.rs 0 3 0.0%
service/src/main.rs 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
service/src/config.rs 1 0.0%
Totals Coverage Status
Change from base Build 6590531530: -0.06%
Covered Lines: 1004
Relevant Lines: 2336

💛 - Coveralls

Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Could you please leave some documentation on available contract addresses one could use, perhaps add a default?

@Theodus
Copy link
Member Author

Theodus commented Oct 24, 2023

I think these options should be set explicitly, rather than having a default. I agree we should add a link to an address book for the deployed contracts, as soon as one is available.

@Theodus Theodus merged commit 1bd7650 into main Oct 24, 2023
4 checks passed
@Theodus Theodus deleted the theodus/receipts branch October 24, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants