fix(service): ms intervals treated as seconds #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexis Asseman <[email protected]>
aasseman
added
size:small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the indexer-service arguments are asking for ms:
https://github.com/graphops/indexer-service-rs/blob/b603c306969e1a202ea15381438cde3a5204dcc3/service/src/config.rs#L211-L218
https://github.com/graphops/indexer-service-rs/blob/b603c306969e1a202ea15381438cde3a5204dcc3/service/src/config.rs#L260-L267
(I'll fix clap for this second one later)
This is carried from the original
indexer-service. Even though asking for seconds directly may make more sense, that would introduce a breaking change for users.