Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type network subgraph deployment strongly #67

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Oct 12, 2023

This is based on #65 and will need to be rebased after that has been merged. Only the most recent commit in this PR is actually new.

@aasseman aasseman added size:small Small p2 Medium priority type:refactor Changes not visible to users labels Oct 12, 2023
@Jannis Jannis force-pushed the jannis/moar-deployment-id branch from 74ad259 to 576561f Compare October 17, 2023 20:13
@github-actions
Copy link
Contributor

Pull Request Test Coverage Report for Build 6552330831

  • 285 of 335 (85.07%) changed or added relevant lines in 9 files are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-1.8%) to 40.496%

Changes Missing Coverage Covered Lines Changed/Added Lines %
common/src/attestations/signers.rs 50 52 96.15%
service/src/server/mod.rs 0 2 0.0%
service/src/query_processor.rs 4 10 40.0%
service/src/tap_manager.rs 0 7 0.0%
common/src/allocations/monitor.rs 159 174 91.38%
service/src/main.rs 0 18 0.0%
Files with Coverage Reduction New Missed Lines %
common/src/allocations/monitor.rs 1 91.88%
common/src/attestations/signers.rs 1 95.0%
service/src/main.rs 1 0.0%
service/src/tap_manager.rs 1 0.0%
Totals Coverage Status
Change from base Build 6519277925: -1.8%
Covered Lines: 914
Relevant Lines: 2257

💛 - Coveralls

aasseman
aasseman previously approved these changes Oct 17, 2023
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: (after rebase onto latest main)

@Jannis Jannis dismissed aasseman’s stale review October 17, 2023 21:00

The merge-base changed after approval.

@Jannis Jannis force-pushed the jannis/moar-deployment-id branch from 576561f to d73387e Compare October 17, 2023 21:00
Copy link
Contributor

@aasseman aasseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Jannis Jannis merged commit 93e9c95 into main Oct 17, 2023
4 checks passed
@Jannis Jannis deleted the jannis/moar-deployment-id branch October 17, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 Medium priority size:small Small type:refactor Changes not visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants