Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TAP receipts handling + Escrow monitor #47

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

aasseman
Copy link
Contributor

I split changes into multiple commits for easier review.

This implementation of TAP only checks for the correct signatures and stores the receipt into PG. PG will notify listeners (future TAP aggregate requester agent) about the new receipts so that it can cheaply and easily track how much outstanding balance we've got and whether to trigger a RAV request.

Changing Address from ethers-rs to alloy was needed for the tap_core update

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman added size:large Large p1 High priority type:feature New or enhanced functionality labels Sep 14, 2023
@aasseman aasseman requested a review from hopeyen September 14, 2023 19:13
@aasseman aasseman self-assigned this Sep 14, 2023
@aasseman
Copy link
Contributor Author

service/src/escrow_monitor.rs Show resolved Hide resolved
service/src/tap_manager.rs Show resolved Hide resolved
@aasseman aasseman changed the title TAP receipts handling + Escrow monitor feat: TAP receipts handling + Escrow monitor Sep 14, 2023
Copy link
Collaborator

@hopeyen hopeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So happy to see the TAP manager

@aasseman aasseman merged commit dd605f3 into main Sep 15, 2023
@aasseman aasseman deleted the aasseman/tap_receipts_minimal branch September 15, 2023 17:31
This was referenced Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority size:large Large type:feature New or enhanced functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants