Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sender fee tracker metric #439

Closed
wants to merge 6 commits into from
Closed

feat: add sender fee tracker metric #439

wants to merge 6 commits into from

Conversation

gusinacio
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Oct 30, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11635035355

Details

  • 57 of 57 (100.0%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 74.861%
Files with Coverage Reduction New Missed Lines %
common/src/tap/checks/deny_list_check.rs 1 98.21%
Totals Coverage Status
Change from base Build 11632923391: 0.1%
Covered Lines: 5375
Relevant Lines: 7180
💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/new-metric-for-sender-fee-tracker branch from 9043768 to cf6210b Compare October 30, 2024 20:53
@gusinacio gusinacio marked this pull request as ready for review October 30, 2024 22:20
@gusinacio gusinacio requested a review from carlosvdr October 30, 2024 22:20
suchapalaver
suchapalaver reviewed Oct 30, 2024
View reviewed changes
tap-agent/src/agent/sender_account.rs
Comment on lines 62 to 63
"tap_invalid_receipt_fees_grt_total",
"Failed receipt fees",
Copy link
Contributor

@suchapalaver suchapalaver Oct 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no need to pass something like &["sender"] here as above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's, take a look on line 64

@gusinacio gusinacio force-pushed the gustavo/new-metric-for-sender-fee-tracker branch from c9a0753 to 235b208 Compare November 1, 2024 19:17
@gusinacio gusinacio closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suchapalaver suchapalaver suchapalaver left review comments

@carlosvdr carlosvdr Awaiting requested review from carlosvdr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gusinacio @coveralls @suchapalaver