Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tap-agent): EIP712 domain separator name #117

Merged
merged 1 commit into from
Feb 2, 2024
Merged

fix(tap-agent): EIP712 domain separator name #117

merged 1 commit into from
Feb 2, 2024

Conversation

aasseman
Copy link
Contributor

@aasseman aasseman commented Feb 2, 2024

Quick fix before we update to a more recent version of tap-core that provides a single source of truth for the EIP-712 domain separator.

@aasseman aasseman added size:small Small p0 Critical priority type:bug Something isn't working labels Feb 2, 2024
@aasseman aasseman requested a review from gusinacio February 2, 2024 21:57
@aasseman aasseman self-assigned this Feb 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7761973305

  • -1 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 63.178%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent.rs 0 1 0.0%
Totals Coverage Status
Change from base Build 7759912810: 0.0%
Covered Lines: 2445
Relevant Lines: 3870
💛 - Coveralls

@aasseman aasseman merged commit d16470f into main Feb 2, 2024
8 checks passed
@aasseman aasseman deleted the aasseman/fix_tap_agent_domain_sep branch February 2, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gusinacio gusinacio gusinacio approved these changes

Assignees

@aasseman aasseman

Labels
p0 Critical priority size:small Small type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aasseman @coveralls @gusinacio