Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: drop the manager handler correctly #107

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

gusinacio
Copy link
Member

The current implementation implements the Drop trait for the manager by aborting the handler.

The manager was being dropped at the end of create_agent() and wouldn't execute the thread correctly. This PR transfer the ownership to the main function which is dropped correctly when the execution is terminated.

@gusinacio gusinacio requested a review from aasseman December 13, 2023 22:38
Copy link
Contributor

Pull Request Test Coverage Report for Build 7201920144

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.07%) to 63.213%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/agent.rs 0 3 0.0%
tap-agent/src/main.rs 0 9 0.0%
Files with Coverage Reduction New Missed Lines %
tap-agent/src/agent.rs 1 0.0%
tap-agent/src/tap/sender_allocation_relationships_manager.rs 2 68.02%
Totals Coverage Status
Change from base Build 7197062158: -0.07%
Covered Lines: 2294
Relevant Lines: 3629

💛 - Coveralls

@aasseman aasseman merged commit 6c08697 into main Dec 14, 2023
7 checks passed
@aasseman aasseman deleted the gusinacio/fix-drop-manager branch December 14, 2023 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants