-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port subgraph indexer-service to the indexer service framework #104
Conversation
c6f220b
to
6f7316a
Compare
cb9adee
to
f9f4728
Compare
21fa80d
to
daa7acd
Compare
882d7f0
to
760df33
Compare
69aa73a
to
82c2b60
Compare
82c2b60
to
0434d96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a couple questions.
Also a test is failing.
Added the optional, previously missing |
9379047
to
718e96d
Compare
718e96d
to
138a5e6
Compare
@aasseman Tests are passing now 😄 |
This partly reimplements the existing Rust indexer-service and ports it to the HTTP indexer framework that was merged in #80. I've tested this using a local network environment setup, to make sure that various pieces work, including
I can confirm that all of this works end to end.
And thanks to using the framework, we're able to delete ~1200 lines of code.