server: improve warning message for graphman graphql api and clean up…

… code
graphprotocol · Dec 26, 2024 · 8bdc003 · 8bdc003
1 parent dd1e299
commit 8bdc003
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/server/graphman/src/entities/warning_response.rs b/server/graphman/src/entities/warning_response.rs
@@ -6,8 +6,7 @@ pub struct CompletedWithWarnings {
 }
 
 impl CompletedWithWarnings {
-    /// Returns a response with success & message.
-    pub fn new(msg: Vec<String>) -> Self {
-        Self { warnings: msg }
+    pub fn new(warnings: Vec<String>) -> Self {
+        Self { warnings }
     }
 }
diff --git a/server/graphman/src/resolvers/deployment_mutation.rs b/server/graphman/src/resolvers/deployment_mutation.rs
@@ -124,7 +124,7 @@ impl DeploymentMutation {
         let mirror = catalog::Mirror::primary_only(ctx.primary_pool);
         let count = mirror.assignments(&node)?.len();
         if count == 1 {
-            let warning_msg = format!("warning: this is the only deployment assigned to '{}'. Are you sure it is spelled correctly?",node.as_str());
+            let warning_msg = format!("This is the only deployment assigned to '{}'. Please make sure that the node ID is spelled correctly.",node.as_str());
             Ok(ReassignResponse::CompletedWithWarnings(
                 CompletedWithWarnings::new(vec![warning_msg]),
             ))

diff --git a/server/graphman/tests/deployment_mutation.rs b/server/graphman/tests/deployment_mutation.rs
@@ -423,7 +423,7 @@ fn graphql_can_unassign_deployments() {
 
         let subgraph_node_id = send_graphql_request(
             json!({
-                "query": r#"query Deployment {
+                "query": r#"{
                     deployment {
                         info(deployment: { hash: "subgraph_1" }) {
                             nodeId