Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance refactors #45

Merged
merged 10 commits into from
May 24, 2024
Merged

Performance refactors #45

merged 10 commits into from
May 24, 2024

Conversation

juanmardefago
Copy link
Collaborator

@juanmardefago juanmardefago commented May 22, 2024

Schema changes:

  • Replaced almost all entity IDs with Bytes. Only GraphAccountName still uses ID because of how the id itself was generated.
  • Replaced all usages of String to represent entity links with the newly corresponding Bytes
  • By replacing ID with Bytes, the IDs themselves have been altered, so they will not match with previous implementations or with the core network subgraph currently (since it still uses String/ID IDs)
  • Transaction entities are now immutable
  • IndexerDelegatedStakeRelation now only has an ID and a link to the indexer, for performance purposes when handling indexers with lots of delegations

Tests:

  • Added a small test to make sure our new Bytes based ID approach works correctly.

@juanmardefago juanmardefago merged commit 0cfa7e1 into master May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant