Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transfer to The Graph Cookbook #803

Merged
merged 7 commits into from
Nov 15, 2024
Merged

Transfer to The Graph Cookbook #803

merged 7 commits into from
Nov 15, 2024

Conversation

idalithb
Copy link
Contributor

@idalithb idalithb commented Oct 24, 2024 •
edited
Loading

-Adding potential cookbook
-co-editor/writer @alinobrasil

@idalithb idalithb changed the title Cookbook Transfer to The Graph Cookbook Oct 24, 2024
@idalithb idalithb marked this pull request as ready for review October 25, 2024 17:36
@idalithb idalithb requested a review from a team as a code owner October 25, 2024 17:36
schmidsi
schmidsi requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@schmidsi schmidsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great cookbook! I left some comments that might improve it a bit.

website/pages/en/cookbook/transfer-to-the-graph.mdx Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/transfer-to-the-graph.mdx Show resolved Hide resolved
alinobrasil
alinobrasil approved these changes Nov 1, 2024
View reviewed changes
Copy link

@alinobrasil alinobrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Images aren't showing in the preview so just make sure these images really are there.

@idalithb
Copy link
Contributor Author

idalithb commented Nov 1, 2024

LGTM. Images aren't showing in the preview so just make sure these images really are there.

TY! Sounds good.

MichaelMacaulay
MichaelMacaulay approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@MichaelMacaulay MichaelMacaulay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work! Very exciting!

@idalithb idalithb removed the request for review from schmidsi November 12, 2024 19:24
@benface benface merged commit 19adf25 into main Nov 15, 2024
4 checks passed
@benface benface deleted the migrate branch November 15, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface left review comments

@schmidsi schmidsi schmidsi requested changes

@chidubemokeke chidubemokeke chidubemokeke approved these changes

@MichaelMacaulay MichaelMacaulay MichaelMacaulay approved these changes

@alinobrasil alinobrasil alinobrasil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@idalithb @schmidsi @benface @alinobrasil @MichaelMacaulay @chidubemokeke