Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookbook-Enums #798

Merged
merged 9 commits into from
Nov 15, 2024
Merged

Cookbook-Enums #798

merged 9 commits into from
Nov 15, 2024

Conversation

idalithb
Copy link
Contributor

-Needs review
-Missing page in other languages

@idalithb idalithb requested a review from a team as a code owner October 17, 2024 22:13
@idalithb idalithb marked this pull request as draft October 17, 2024 22:17
schmidsi
schmidsi requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@schmidsi schmidsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. I left some comments to make this a bit clearer.

website/pages/en/cookbook/_meta.js Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
@chidubemokeke
Copy link

Looking good, thanks a ton for the support!

chidubemokeke
chidubemokeke approved these changes Oct 25, 2024
View reviewed changes
Copy link

@chidubemokeke chidubemokeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the edits, super thankful.

@idalithb idalithb closed this Oct 25, 2024
@idalithb
Copy link
Contributor Author

idalithb commented Oct 25, 2024 •
edited
Loading

Love the edits, super thankful.

@chidubemokeke Wonderful! Happy to collab anytime! :)

@idalithb idalithb reopened this Oct 25, 2024
@idalithb idalithb marked this pull request as ready for review October 25, 2024 16:59
@chidubemokeke
Copy link

Love the edits, super thankful.

@chidubemokeke Wonderful! Happy to collab anytime! :)

It's soothing to see new contributions from a different perspective.

Super thankful to @schmidsi for the referral

alinobrasil
alinobrasil reviewed Nov 12, 2024
View reviewed changes
Copy link

@alinobrasil alinobrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few edit suggestions, mostly in the beginning.

website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Outdated Show resolved Hide resolved
website/pages/en/cookbook/enums.mdx Show resolved Hide resolved
alinobrasil
alinobrasil approved these changes Nov 14, 2024
View reviewed changes
Copy link

@alinobrasil alinobrasil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@benface benface merged commit 5a22177 into main Nov 15, 2024
4 checks passed
@benface benface deleted the cookbook-enums branch November 15, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benface benface benface left review comments

@chidubemokeke chidubemokeke chidubemokeke approved these changes

@alinobrasil alinobrasil alinobrasil approved these changes

@schmidsi schmidsi Awaiting requested review from schmidsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@idalithb @chidubemokeke @schmidsi @benface @alinobrasil