Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump urql to 3.1.0 #120

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Bump urql to 3.1.0 #120

merged 1 commit into from
Oct 8, 2024

Conversation

dwerner
Copy link
Contributor

@dwerner dwerner commented Oct 7, 2024 •
edited
Loading

We want this upstream memory leak fix: urql-graphql/urql#2850

@dwerner dwerner requested a review from fordN October 7, 2024 23:56
@dwerner dwerner added the bug Something isn't working label Oct 8, 2024
@encalypto encalypto self-requested a review October 8, 2024 14:29
encalypto
encalypto approved these changes Oct 8, 2024
View reviewed changes
Copy link

@encalypto encalypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find! This explains the millions of urql return objects floating around in heap memory

@dwerner dwerner merged commit 1fb1b86 into master Oct 8, 2024
4 checks passed
@dwerner dwerner mentioned this pull request Oct 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@encalypto encalypto encalypto approved these changes

@fordN fordN Awaiting requested review from fordN

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dwerner @encalypto