Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add basic chain aliasing and encoding for it #255

Merged
merged 4 commits into from
May 6, 2024

Conversation

juanmardefago
Copy link
Collaborator

@juanmardefago juanmardefago commented Apr 4, 2024

Adds a new message (RegisterNetworksAndAliases, tag 6) that allows to add a new network with a specific alias.
The intended use is to be able to allow for future proofing of chain aliases, while still allowing previously registered networks to be aliased through a preloaded aliases list (which includes all networks currently on any EBO, as well as most networks from hosted service)

@juanmardefago juanmardefago requested a review from Maikol April 4, 2024 06:09
@juanmardefago
Copy link
Collaborator Author

Only caveat I would like to add is that the Oracle has no knowledge of aliases, but we don't really expect the Oracle to be sending register network messages, let alone alias messages

Copy link
Member

@Maikol Maikol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work 🎉

@juanmardefago juanmardefago merged commit a3fa849 into main May 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants