Don't use exponential backoff for signed transactions #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The transaction monitor does not play well with our current exponengial backoff implementation for JRPC endpoints. For effective monitoring, we must access any errors as soon as they happen, so we must strip out the implicit retry strategies.
tilacog
changed the title
tilacog
changed the title
tilacog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our JSON RPC connections have an unconditional retry strategy.
While this is useful for requests that only read from the chain, it also obfuscates the new transaction monitoring system.
It's crucial for such a system that transaction failures are detected immediately so it can act on them appropriately.
For this reason, this PR removes the exponential backoff mechanism for JSON RPC clients that emit signed transactions.