feat: validate indexer address config variable

graphops · Dec 12, 2023 · 74db359 · 74db359
1 parent 9ba02ac
commit 74db359
Show file tree

Hide file tree

Showing 3 changed files with 51 additions and 2 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/subgraph-radio/src/config.rs b/subgraph-radio/src/config.rs
@@ -3,6 +3,7 @@ use clap::value_parser;
 use clap::{command, Args, Parser};
 use derive_getters::Getters;
 use ethers::signers::WalletError;
+use graphcast_sdk::Account;
 use graphcast_sdk::{
     build_wallet,
     callbook::CallBook,
@@ -28,6 +29,22 @@ pub enum CoverageLevel {
     Comprehensive,
 }
 
+fn is_valid_ethereum_address(address: &str) -> bool {
+    address.len() == 42
+        && address.starts_with("0x")
+        && address[2..].chars().all(|c| c.is_ascii_hexdigit())
+}
+
+fn parse_indexer_address(value: &str) -> Result<String, ConfigError> {
+    if !is_valid_ethereum_address(value) {
+        return Err(ConfigError::ValidateInput(
+            "Invalid Ethereum address".to_string(),
+        ));
+    }
+
+    Ok(value.to_string())
+}
+
 #[derive(Clone, Debug, Parser, Serialize, Deserialize, Getters, Default)]
 #[clap(
     name = "subgraph-radio",
@@ -72,6 +89,35 @@ impl Config {
         config
     }
 
+    pub async fn validate_indexer_address(&self) {
+        let input = self.wallet_input().unwrap();
+        let wallet = build_wallet(input).unwrap();
+        let agent = wallet_address(&wallet);
+
+        let account = Account::new(
+            agent.to_ascii_lowercase(),
+            self.graph_stack()
+                .indexer_address()
+                .to_string()
+                .to_ascii_lowercase(),
+        );
+
+        let verified = account
+            .verify(
+                self.graph_stack().network_subgraph(),
+                self.graph_stack().registry_subgraph(),
+                &IdentityValidation::Indexer,
+            )
+            .await;
+
+        if verified.is_err() {
+            panic!(
+                "Indexer address validation failed: {:?}",
+                verified.unwrap_err()
+            );
+        }
+    }
+
     /// Validate that private key as an Eth wallet
     fn parse_key(value: &str) -> Result<String, WalletError> {
         // The wallet can be stored instead of the original private key
@@ -220,6 +266,7 @@ pub struct GraphStack {
     pub graph_node_status_endpoint: String,
     #[clap(
         long,
+        value_parser = parse_indexer_address,
         value_name = "INDEXER_ADDRESS",
         env = "INDEXER_ADDRESS",
         help = "Graph account corresponding to Graphcast operator"

diff --git a/subgraph-radio/src/operator/mod.rs b/subgraph-radio/src/operator/mod.rs
@@ -97,6 +97,8 @@ impl RadioOperator {
         debug!("Set global static instance of graphcast_agent");
         _ = GRAPHCAST_AGENT.set(graphcast_agent.clone());
 
+        config.validate_indexer_address().await;
+
         //TODO: Refactor indexer management server validation to SDK, similar to graph node status endpoint
         if let Some(url) = &config.graph_stack.indexer_management_server_endpoint {
             _ = health_query(url)