fix: remove default extraArgs for rpcdaemon

graphops · Sep 11, 2022 · 2fd8a27 · 2fd8a27
1 parent 7671a84
commit 2fd8a27
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 12 deletions.
diff --git a/charts/erigon/Chart.yaml b/charts/erigon/Chart.yaml
@@ -15,7 +15,7 @@ type: application
 # This is the chart version. This version number should be incremented each time you make changes
 # to the chart and its templates, including the app version.
 # Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 0.2.5
+version: 0.2.6
 
 # This is the version number of the application being deployed. This version number should be
 # incremented each time you make changes to the application. Versions are not expected to

diff --git a/charts/erigon/README.md b/charts/erigon/README.md
@@ -2,7 +2,7 @@
 
 Deploy and scale [Erigon](https://github.com/ledgerwatch/erigon) inside Kubernetes with ease
 
-[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) ![Version: 0.2.5](https://img.shields.io/badge/Version-0.2.5-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2022.09.01](https://img.shields.io/badge/AppVersion-v2022.09.01-informational?style=flat-square)
+[![License](https://img.shields.io/badge/License-Apache%202.0-blue.svg)](https://opensource.org/licenses/Apache-2.0) ![Version: 0.2.6](https://img.shields.io/badge/Version-0.2.6-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: v2022.09.01](https://img.shields.io/badge/AppVersion-v2022.09.01-informational?style=flat-square)
 
 ## Features
 
@@ -80,7 +80,7 @@ We do not recommend that you upgrade the application by overriding `image.tag`.
  | rpcdaemon.autoscaling.targetCPUUtilizationPercentage |  | int | `75` |
  | rpcdaemon.autoscaling.targetMemoryUtilizationPercentage |  | string | `nil` |
  | rpcdaemon.enabled | Enable a Deployment of rpcdaemon that can be scaled independently | bool | `true` |
- | rpcdaemon.extraArgs | Additional CLI arguments to pass to `rpcdaemon` | list | `["--http.api=eth,debug,net,trace","--trace.maxtraces=10000","--http.vhosts=*","--http.corsdomain=*","--ws","--rpc.batch.concurrency=4","--state.cache=2000000"]` |
+ | rpcdaemon.extraArgs | Additional CLI arguments to pass to `rpcdaemon` | list | `[]` |
  | rpcdaemon.nodeSelector |  | object | `{}` |
  | rpcdaemon.podAnnotations | Annotations for the `Pod` | object | `{}` |
  | rpcdaemon.podSecurityContext | Pod-wide security context | object | `{"fsGroup":101337,"runAsGroup":101337,"runAsNonRoot":true,"runAsUser":101337}` |

diff --git a/charts/erigon/templates/rpcdaemon/deployment.yaml b/charts/erigon/templates/rpcdaemon/deployment.yaml
@@ -56,9 +56,9 @@ spec:
             - --private.api.addr={{ include "erigon.fullname" . }}-stateful-node:{{ get $.Values.statefulNode.service.ports "grpc-erigon" }} # grpc interface of stateful process
             - --http.addr=0.0.0.0
             - --http.port=8545
+            - --http.vhosts=*
             - --metrics
             - --metrics.addr=0.0.0.0
-            - --http.vhosts=*
             {{- with $values.extraArgs }}
               {{- toYaml (. | default list) | nindent 12 }}
             {{- end }}

diff --git a/charts/erigon/values.yaml b/charts/erigon/values.yaml
@@ -115,14 +115,7 @@ rpcdaemon:
   replicaCount: 2
 
   # -- Additional CLI arguments to pass to `rpcdaemon`
-  extraArgs:
-      - "--http.api=eth,debug,net,trace"
-      - "--trace.maxtraces=10000" # optional
-      - "--http.vhosts=*" # optional
-      - "--http.corsdomain=*" # optional
-      - "--ws" # enable ws
-      - "--rpc.batch.concurrency=4" # default 2
-      - "--state.cache=2000000" # default 1000000, only makes sense for rpcdaemon without --datadir
+  extraArgs: []
 
   # -- Annotations for the `Pod`
   podAnnotations: {}