Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: basic metrics, separate from indexer-rs metrics #59

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Mar 15, 2024

Description

Added metrics for response time for file requests and Number of bytes transferred per request per file.

  • Response Time: Average response time for file requests.
  • Throughput: Number of requests handled per unit of time (e.g., requests per second). IndexerServiceMetrics has request counter, the metrics can be built from that
  • Error Rate: Percentage of requests resulting in errors. Failure count is tracked by IndexerServiceMetrics
  • Data Transfer Efficiency: Amount of data successfully transferred versus requested.
  • Uptime and Availability: Percentage of time the server is operational and accessible. Should be tracked by infra
  • Request Distribution: Distribution of requests across different files. This can be built from query counter

Issue link (if applicable)

resolves #24

Checklist

  • Are tests up-to-date with the new changes?
  • Are docs up-to-date with the new changes? (Open PR on docs repo if necessary)

@hopeyen hopeyen self-assigned this Mar 15, 2024
@hopeyen hopeyen added size:small Small p3 Low priority labels Mar 15, 2024
Copy link

Pull Request Test Coverage Report for Build 8345184095

Details

  • 0 of 67 (0.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 0.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
file-service/src/main.rs 0 1 0.0%
file-service/src/file_server/range.rs 0 2 0.0%
file-service/src/file_server/mod.rs 0 4 0.0%
file-service/src/metrics.rs 0 60 0.0%
Totals Coverage Status
Change from base Build 8195152037: 0.0%
Covered Lines: 0
Relevant Lines: 3653

💛 - Coveralls

@hopeyen hopeyen merged commit 8431b80 into dev Mar 19, 2024
5 checks passed
@hopeyen hopeyen deleted the hope/metrics branch March 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3 Low priority size:small Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Metrics for the server
1 participant