Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: documentation adjustments #40

Merged
merged 1 commit into from
Jan 16, 2024
Merged

feat: documentation adjustments #40

merged 1 commit into from
Jan 16, 2024

Conversation

chriswessels
Copy link
Member

No description provided.

@@ -1,16 +1,8 @@
## Architecture and Components

### Decentralized Architecture
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing here for setting the tone?

@@ -25,7 +25,7 @@ After determining the Bundle CID, client should supply a local path for writing

### CLI example
```
➜ file-exchange git:(main) ✗ cargo run -p file-exchange downloader \
$ fhs downloader \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about using fhs as the CLI command 🤔 file-hosting, graph-file...?

@hopeyen
Copy link
Collaborator

hopeyen commented Jan 15, 2024

Docker failed because the image filename should be updated, I would say Dockerfile.file-exchange, but we can first agree on a crate name for the current file-exchange, if there's anything better than fhs

@hopeyen hopeyen force-pushed the chris/doc-adjustments branch from fd5194c to dc67ebd Compare January 16, 2024 16:29
Copy link

Pull Request Test Coverage Report for Build 7544601781

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 39.02%

Totals Coverage Status
Change from base Build 7544515877: 0.0%
Covered Lines: 1043
Relevant Lines: 2673

💛 - Coveralls

@hopeyen hopeyen merged commit 14739f3 into dev Jan 16, 2024
5 checks passed
@hopeyen hopeyen deleted the chris/doc-adjustments branch January 16, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants