validation errors appear when relationship has nested records #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We ran across an issue with spraypaint in which we have an object that is deeply nested and has many associations with < grand children > with below hierarchy ;
Parent < has many > children and <childern> has many < grand children>
Spraypaint expects relationship errors to be nested but GraphitiErrors does not provide much information for the < grandchildren > records and aborts on associating errors with result objects and results in errors on clientside in the console of the browser.
Solution:
When spraypaint transverse the path structure of the errors, it doesn't get the relatedRecord object for deeply nested grandchildren and return the exception which can be avoided to check if we have relatedRecord before executing the error block. With this new patch, errors for missing grandchildren will be silently dropped which is still better than crashing the application.
Motivation:
Crashing the client application gives a bad impact, rather ignore for smooth operation to return.