Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validation errors appear when relationship has nested records #101

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfahadm
Copy link

@mfahadm mfahadm commented Sep 16, 2021

Problem
We ran across an issue with spraypaint in which we have an object that is deeply nested and has many associations with < grand children > with below hierarchy ;

Parent < has many > children and <childern> has many < grand children>

Spraypaint expects relationship errors to be nested but GraphitiErrors does not provide much information for the < grandchildren > records and aborts on associating errors with result objects and results in errors on clientside in the console of the browser.

Solution:

When spraypaint transverse the path structure of the errors, it doesn't get the relatedRecord object for deeply nested grandchildren and return the exception which can be avoided to check if we have relatedRecord before executing the error block. With this new patch, errors for missing grandchildren will be silently dropped which is still better than crashing the application.

Motivation:

Crashing the client application gives a bad impact, rather ignore for smooth operation to return.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant