Merge pull request #61 from mkessler/master

Fix validation error ID comparison
graphiti-api · Mar 18, 2020 · 74ee9ad · 74ee9ad
2 parents 84027ad + a3b2429
commit 74ee9ad
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/src/util/validation-error-builder.ts b/src/util/validation-error-builder.ts
@@ -71,8 +71,6 @@ export class ValidationErrorBuilder<T extends SpraypaintBase> {
     let relatedObject = model[model.klass.deserializeKey(meta.name)]
     if (Array.isArray(relatedObject)) {
       relatedObject = relatedObject.find(r => {
-        if (meta["temp-id"] === undefined) return r.id === meta.id
-
         // For now graphiti is returning the related object id as an integer
         // where the related object's ID is a string
         return (

diff --git a/test/integration/validations.test.ts b/test/integration/validations.test.ts
@@ -401,7 +401,8 @@ describe("validations (3/3)", () => {
       detail: "Title cannot be blank",
       meta: {
         relationship: {
-          id: "30",
+          // For some reason graphiti is returning these as integers
+          id: 30,
           // ["temp-id"]: "abc1",
           name: "books",
           type: "books",