Merge pull request #41 from ogd-software/master

Enable developers to read response.json() when ResponseError is being thrown
graphiti-api · Sep 9, 2019 · 531d35d · 531d35d
2 parents f065d2e + ee29c75
commit 531d35d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/request.ts b/src/request.ts
@@ -125,7 +125,7 @@ export class Request {
 
     let json
     try {
-      json = await response.json()
+      json = await response.clone().json()
     } catch (e) {
       if (response.status === 202) return
       throw new ResponseError(response, "invalid json", e)

diff --git a/test/integration/fetch-middleware.test.ts b/test/integration/fetch-middleware.test.ts
@@ -217,11 +217,13 @@ describe("fetch middleware", () => {
           .then(({ data }) => {
             expect("dont get here!").to.eq(true)
           })
-          .catch(e => {
+          .catch(async e => {
             expect(e.message).to.eq(
               "afterFetch failed; review middleware.afterFetch stack"
             )
             expect(e.response.status).to.eq(401)
+            // If fetch.clone method is not used, error for getting json is: body used already for: URL
+            expect(await e.response.json()).to.be.an("object")
             expect(e.originalError).to.eq(ABORT_ERR)
           })
       })
@@ -392,11 +394,13 @@ describe("fetch middleware", () => {
           .then(() => {
             expect("dont get here!").to.eq(true)
           })
-          .catch(e => {
+          .catch(async e => {
             expect(e.message).to.eq(
               "afterFetch failed; review middleware.afterFetch stack"
             )
             expect(e.response.status).to.eq(401)
+            // If fetch.clone method is not used, error for getting json is: body used already for: URL
+            expect(await e.response.json()).to.be.an("object")
             expect(e.originalError).to.eq(ABORT_ERR)
           })
       })