Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show includes for sideloads in debugger #462

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

bebbs
Copy link
Contributor

@bebbs bebbs commented Feb 15, 2024

Could the debugger show the include key in its output? It caused me some confusion as it wasn't showing up in the logs, but the data was being sideloaded with the include as I'd expect.

Before:

=== Graphiti Debug
Top Level Data Retrieval (+ sideloads):
VehicleResource.all({:filter=>{:id=>"car_123"}, :include=>"cheapest_used_cash_deal", :pagination_links=>true})
Took: 33.59ms
    \_ cheapest_used_cash_deal
       DealResource.all({:filter=>{:type=>"CASH"}, :sort=>"price"})
       Took: 1164.34ms

After:

=== Graphiti Debug
Top Level Data Retrieval (+ sideloads):
VehicleResource.all({:filter=>{:id=>"car_123"}, :include=>"cheapest_used_cash_deal", :pagination_links=>true})
Took: 44.45ms
    \_ cheapest_used_cash_deal
       DealResource.all({:filter=>{:type=>"CASH"}, :include=>"vehicle", :sort=>"price"})
       Took: 971.99ms

@jkeen
Copy link
Collaborator

jkeen commented Feb 27, 2024

This makes a lot of sense to me—this has bitten me before as well.

@jkeen jkeen merged commit 3766e9d into graphiti-api:master Feb 27, 2024
22 of 25 checks passed
@bebbs bebbs deleted the fix-include-debugger branch February 29, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants