Solve issue with url?.startsWith and various others #2380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 355a9ac The changes in this PR will be included in the next version bump. This PR includes changesets to release 81 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@paales Hi Paul, are you still working on it? As I see, deployments failed so i am waiting your fixes. |
|
@muzafferkilicaslan Yeah, had a priority thing to do, just pushed the latest changes. Not very happy with the required changes... See commit message here: 1b7cd40 |
|
Hi @paales, i was checking and copying your changes to my locale at that commit but i have some questions. Is this doc is updated https://www.graphcommerce.org/docs/getting-started/create cause i was copying file by file but when packages/cli/dist/bin/mesh.js looking this file changed file i mean original file isn't same my locale file. So i thought that doc might be outdated. Also your last changes seems didn't fix all issues again. Could you help me to install and run Graphcommerce? I mean i can use old versions for now, if you advice me to another version of this i will be pre. I want to test GraphCommerce with my backend asap. Thanks :) |
|
@muzafferkilicaslan I'll provide a patch for the current 8.0.6 installation. But I think you should be able to do the following:
Can you test that out? |
|
@paales Hi Mr. Paul, thanks for your help but i couldn't run it. I'm probably continue with pwa-studio for now. But i will check graphcommerce again in a short time i hope. |
paales
changed the title
…generated `.mesh/index.ts` would be generated as a requirejs module while next.js expects an esm module. In the end we properly generated the mesh correctly and now there is an `import.meta.url` instead of using `require('node:url')`. To solve this we needed to solve a chain of issues:
1. The generation of the mesh is based on the version of the mesh that is imported (esm or commonjs). See [source](https://github.com/ardatan/graphql-mesh/blob/bf588d372c0078378aaa24beea2da794af7949e6/scripts/replace-import-meta-url-in-cjs.ts#L9-L10) for the lines that need to be different. This meant that we needed to change the @graphcommerce/cli package to be of type:module instead of a commonjs module.
2) To properly convert the module to an esm module we've migrated the build of the cli package to use 'pkgroll' instead of tsc, because tsc is limited in what it outputs and can't really convert classic imports to esm.
3) To load possible mesh plugins we require additional .ts files to be loaded with [tsx](https://tsx.is/). To get the tsx loader to work properly in combination with esm modules, we need at least [node 18.19.0](https://nodejs.org/en/blog/release/v18.19.0#new-nodemodule-api-register-for-module-customization-hooks-new-initialize-hook). Minimal Node version upped to 18.19.0 and add support for node 22.
…s only included during development and not in production.
…rs and would use a hard navigation.
…) while rendering a different component (`ActionCardListForm`).
…age after logging out.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.